Update dependencies to v2.18.2 #8
Conversation
AndrewJo
left a comment
AndrewJo
left a comment
There was a problem hiding this comment.
Hey @Alonski, I just reviewed your PR. There are few things that should be fixed (see line comments) but other than that, it looks great!
Thank you for updating this addon to work with the latest Ember.js version! Will merge as soon as requested changes are fixed. 🔧
config/ember-try.js
Outdated
| devDependencies: {} | ||
| } | ||
| } | ||
| } */ |
There was a problem hiding this comment.
Unmatched multiline comment closure.
| <h2 id="title">Welcome to Ember</h2> | ||
|
|
||
| {{outlet}} | ||
| {{outlet}} |
There was a problem hiding this comment.
Missing trailing newline at EOF.
There was a problem hiding this comment.
You want there to be an empty newline at EOF?
tests/helpers/start-app.js
Outdated
| Ember.run(() => { | ||
| application = Application.create(attributes); | ||
| return run(() => { | ||
| let application = Application.create(attributes); |
There was a problem hiding this comment.
It doesn't seem like application is reassigned elsewhere in this closure. Can we switch to a const?
| if (options.afterEach) { | ||
| options.afterEach.apply(this, arguments); | ||
| } | ||
| let afterEach = options.afterEach && options.afterEach.apply(this, arguments); |
There was a problem hiding this comment.
afterEach is not reassigned in this closure. Use const.
.travis.yml
Outdated
| - "4.0" | ||
| # we recommend testing addons with the same minimum supported node version as Ember CLI | ||
| # so that your addon works for all apps | ||
| - "4" |
There was a problem hiding this comment.
Minimum supported Node.js version for Ember CLI is the latest LTS version of Node.js which is 8.10.
|
@AndrewJo Fixed what you commented about |
|
Thanks for the great plugin! Did you by chance release a new version on npm? |
2 participants
After an hour or so of work I have updated this addon to Ember-CLI v2.18.2
This is to remove the deprecation:
Fixes this deprecation:
ember-learn/ember-api-docs#470
Addons not using ember-cli-babel v6 cause this deprecation to pop up:
project.nodeModulesPath Deprecation
Please release a new NPM release.