Handle Checkbox ImageList scaling in Table in win32 #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amartya4256
force-pushed
the
amartya4256/fix_tableItem_scaling
branch
from
b35bfd4 to
521d007
Compare
arunjose696
reviewed
Nov 26, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Outdated
Show resolved
Hide resolved
arunjose696
reviewed
Nov 26, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
amartya4256/fix_tableItem_scaling
branch
from
521d007 to
ab251c0
Compare
This commit handles scaling of ImageList in a table on DPI_CHANGE event by destroying the current imagelist and recalculating the height of the table item and then creating a new imagelist using the new size.
akoch-yatta
force-pushed
the
amartya4256/fix_tableItem_scaling
branch
from
ab251c0 to
878b059
Compare
akoch-yatta
reviewed
Dec 4, 2025
| imageList = null; | ||
| } | ||
|
|
||
| if((style & SWT.CHECK) != 0 ) { |
Contributor
There was a problem hiding this comment.
spacing between if and bracket 😄
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles scaling of ImageList in a table on DPI_CHANGE event by destroying the current imagelist and recalculating the height of the table item and then creating a new imagelist using the new size.
How to test:
Before:
After:
