-
Notifications
You must be signed in to change notification settings - Fork 188
Handle Checkbox ImageList scaling in Table in win32 #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amartya4256
wants to merge
1
commit into
eclipse-platform:master
Choose a base branch
from
vi-eclipse:amartya4256/fix_tableItem_scaling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7336,6 +7336,20 @@ LRESULT wmNotifyToolTip (NMTTCUSTOMDRAW nmcd, long lParam) { | |
| return null; | ||
| } | ||
|
|
||
| void destroyImageList() { | ||
| // Bug in windows: Cannot set the imageList handle to 0 directly, it doesn't | ||
| // seems to cache the previous imageList and show flaky behavior. Instead set | ||
| // the size of the image to the minimum (1,1) and then set the imageList to 0. | ||
| long hImageList = OS.ImageList_Create (1, 1, 0, 0, 0); | ||
| long oldStateImageList = OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_STATE, hImageList); | ||
| long oldhImageList = OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_SMALL, hImageList); | ||
| OS.ImageList_Destroy(oldStateImageList); | ||
| OS.ImageList_Destroy(oldhImageList); | ||
| OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_STATE, 0); | ||
| OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_SMALL, 0); | ||
| OS.ImageList_Destroy(hImageList); | ||
| } | ||
|
|
||
| @Override | ||
| void handleDPIChange(Event event, float scalingFactor) { | ||
| super.handleDPIChange(event, scalingFactor); | ||
|
|
@@ -7358,6 +7372,12 @@ void handleDPIChange(Event event, float scalingFactor) { | |
| imageList = null; | ||
| } | ||
|
|
||
| if((style & SWT.CHECK) != 0 ) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. spacing between if and bracket 😄 |
||
| destroyImageList(); | ||
| int size = getItemHeightInPixels(); | ||
| setCheckboxImageList(size, size, true); | ||
| } | ||
|
|
||
| // if the item height was set at least once programmatically with CDDS_SUBITEMPREPAINT, | ||
| // the item height of the table is not managed by the OS anymore e.g. when the zoom | ||
| // on the monitor is changed, the height of the item will stay at the fixed size. | ||
|
|
@@ -7375,7 +7395,6 @@ void handleDPIChange(Event event, float scalingFactor) { | |
| // Update scrollbar width if no columns are available | ||
| setScrollWidth(scrollWidth); | ||
| } | ||
| fixCheckboxImageListColor (true); | ||
akoch-yatta marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| settingItemHeight = false; | ||
| settingItemHeight = false; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.