-
Notifications
You must be signed in to change notification settings - Fork 553
[desktop lite] Support for Trixie #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scooter-dangle
added a commit
to rubyforgood/human-essentials
that referenced
this pull request
Sep 13, 2025
scooter-dangle
added a commit
to rubyforgood/human-essentials
that referenced
this pull request
Sep 14, 2025
scooter-dangle
added a commit
to rubyforgood/human-essentials
that referenced
this pull request
Sep 14, 2025
See devcontainers/features#1431 See devcontainers/features#1479 We should be able to proceed to debian trixie once the preceding PR is merged. Sundry extras: * the rvm-based install of Ruby wasn't sufficient for our subsequent rbenv-based usage of Ruby * use a 3.4 ruby image * remove port 3000 from forwarded ports per rails/devcontainer#83 (comment) (and that seemed to help)
Kaniska244
suggested changes
Sep 15, 2025
Contributor
Kaniska244
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @byquanton
Thank you for the contribution. Left one comment for correction.
Kaniska244
approved these changes
Sep 15, 2025
Contributor
Kaniska244
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks fine. To be further reviewed by maintainer
AlvaroRausell
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.