Skip to content

feat(api): add quota discount for virt-launcher #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danilrwx wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Draft

feat(api): add quota discount for virt-launcher #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions images/virtualization-artifact/pkg/common/annotations/annotations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,15 @@ const (
// DVCRLabelValue provides a constant for DVCR Pod label values.
DVCRLabelValue = "dvcr-data-importer"

// QuotaExcludeValue provides a constant for exclude quota value.
QuotaExcludeValue = "true"
// QuotaExcludeLabel provides a constant for exclude quota label.
QuotaExcludeLabel = "resource-quota-overrides.deckhouse.io/ignore"
// AnnQuotaDiscountCPU provides a constant for discount CPU from quota annotation.
AnnQuotaDiscountCPU = "resource-quota-overrides.deckhouse.io/discount-cpu"
// AnnQuotaDiscountMemory provides a constant for discount Memory from quota annotation.
AnnQuotaDiscountMemory = "resource-quota-overrides.deckhouse.io/discount-memory"

// InhibitNodeShutdownLabel is a label to prevent node shutdown is Pod with label is present.
InhibitNodeShutdownLabel = "pod.deckhouse.io/inhibit-node-shutdown"

Expand Down
2 changes: 2 additions & 0 deletions images/virtualization-artifact/pkg/controller/vm/internal/sync_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ func PropagateVMMetadata(vm *v1alpha2.VirtualMachine, kvvm *virtv1.VirtualMachin
vm.GetLabels(),
map[string]string{
annotations.InhibitNodeShutdownLabel: "",
annotations.AnnQuotaDiscountCPU: vm.Status.Resources.CPU.RuntimeOverhead.String(),
annotations.AnnQuotaDiscountMemory: vm.Status.Resources.Memory.RuntimeOverhead.String(),
},
)
newLabels, labelsChanged := merger.ApplyMapChanges(destObj.GetLabels(), lastPropagatedLabels, propagateLabels)
Expand Down
Loading