fix: correct event types for handleSelectAll and handleClearAll #5584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Addresses feedback from PR #5470 regarding incorrect event types in
custom-selectcomponent handlers.Changes:
ChangeEventto imports from../../shared/modelhandleSelectAllparameter type fromInputEvent<HTMLInputElement>toChangeEvent<HTMLInputElement>(called fromonChangeevent handler on checkbox)handleClearAllparameter type fromInputEvent<HTMLInputElement>toClickEvent<HTMLButtonElement>(called fromonClickevent handler on DBButton)Each handler now uses the appropriate event type matching how it's invoked:
handleSelectAllis called from anonChangeevent (line 1061-1064 in custom-select.lite.tsx), soChangeEventis correcthandleClearAllis called from anonClickevent (line 1179 in custom-select.lite.tsx), soClickEventis correctTypes of changes
Further comments
This is a stacked PR addressing specific review feedback from #5470. The type corrections ensure proper TypeScript type safety for event handlers by matching each parameter type to its actual usage in the component.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/copilot/sub-pr-5470