Skip to content

Commit 9c09a53

Browse files
Copilotcopilot-swe-agent[bot]mfranzke
authored
fix: correct event types for handleSelectAll and handleClearAll (#5584)
* Initial plan * fix: change handleSelectAll and handleClearAll parameter types to ChangeEvent Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com> * fix: correct handleClearAll to use ClickEvent for onClick handler Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <github-actions@github.com> Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
1 parent 608c713 commit 9c09a53

File tree

1 file changed

+6
-3
lines changed
  • packages/components/src/components/custom-select

1 file changed

+6
-3
lines changed

packages/components/src/components/custom-select/model.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {
22
BaseFormProps,
3+
ChangeEvent,
34
ClickEvent,
45
CloseEventState,
56
CustomFormProps,
@@ -283,8 +284,8 @@ export type DBCustomSelectDefaultState = {
283284
) => void;
284285
handleSummaryFocus: () => void;
285286
handleSelect: (value?: string) => void;
286-
handleSelectAll: (event: InputEvent<HTMLInputElement>) => void;
287-
handleClearAll: (event: InputEvent<HTMLInputElement>) => void;
287+
handleSelectAll: (event: ChangeEvent<HTMLInputElement>) => void;
288+
handleClearAll: (event: ClickEvent<HTMLButtonElement>) => void;
288289
handleDropdownToggle: (event: GeneralEvent<HTMLDetailsElement>) => void;
289290
handleDocumentClose: (event: GeneralEvent<HTMLElement>) => void;
290291
handleOpenByKeyboardFocus: () => void;
@@ -293,7 +294,9 @@ export type DBCustomSelectDefaultState = {
293294
event: GeneralKeyboardEvent<HTMLDetailsElement>
294295
) => void;
295296
handleArrowDownUp: (event: GeneralKeyboardEvent<HTMLElement>) => void;
296-
handleSearch: (valueOrEvent?: InputEvent<HTMLInputElement> | string | void) => void;
297+
handleSearch: (
298+
valueOrEvent?: InputEvent<HTMLInputElement> | string | void
299+
) => void;
297300
handleOptionSelected: (_values: string[]) => void;
298301
getSelectAllLabel: () => string;
299302
selectAllChecked: boolean;

0 commit comments

Comments
 (0)