Skip to content

fix: h1 visibility test by waiting for network idle #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix: h1 visibility test by waiting for network idle #5568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f7c46
Initial plan
Copilot Dec 3, 2025
7a11be2
Fix h1 visibility test by waiting for network idle and fixing variabl…
Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions showcases/patternhub/tests/default.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const getDefaultScreenshotTest = async (
) => {
test(`${type} should match screenshot`, async ({ page }) => {
await page.goto(`${path}`, {
waitUntil: 'domcontentloaded'
waitUntil: 'networkidle'
});
await fn(page);
await expect(page).toHaveScreenshot([name, 'patternhub.png']);
Expand All @@ -35,8 +35,8 @@ for (const group of Components) {
`overview`,
`.${group.path}/${component.name}/overview?fullscreen=true`,
async (page) => {
const firstH2 = page.locator('h1').first();
await expect(firstH2).toBeVisible();
const firstH1 = page.locator('h1').first();
await expect(firstH1).toBeVisible();
}
);
});
Expand Down