fix: h1 visibility test by waiting for network idle
#5568
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The patternhub overview tests fail intermittently because h1 elements are checked before React finishes hydrating. The
DefaultPagecomponent uses dynamic imports with SSR disabled, so content only renders after client-side JavaScript executes.Changes:
waitUntilfrom'domcontentloaded'to'networkidle'in test helper to ensure JavaScript execution completes before asserting element visibilityfirstH2→firstH1(was already querying h1 elements)resolves https://github.com/db-ux-design-system/core-team/issues/1512
Types of changes
Further comments
The
networkidlestrategy waits until no network connections exist for ≥500ms, ensuring dynamic imports and React hydration complete before tests run. This eliminates the race condition without adding artificial delays.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www-api.ibm.com/opt/hostedtoolcache/node/24.11.1/x64/bin/node node /home/REDACTED/work/core-web/core-web/node_modules/@ibm/telemetry-js/dist/REDACTED-process.js --log=/tmp/ibmtelemetry-20251203T165307876Z-840652.log --config=telemetry.yml(dns block)/opt/hostedtoolcache/node/24.11.1/x64/bin/node node /home/REDACTED/work/core-web/core-web/node_modules/@ibm/telemetry-js/dist/REDACTED-process.js --log=/tmp/ibmtelemetry-20251203T165628811Z-612582.log --config=telemetry.yml(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/copilot/fix-h1-visibility-test