-
Notifications
You must be signed in to change notification settings - Fork 76
Add comprehensive test coverage for cuddZddFuncs.c #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0.0
Are you sure you want to change the base?
Conversation
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
|
@copilot Deeply investigate solutions to increase code coverage over 90%. |
…ge now 61.17% Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Investigated and improved coverage from 58.36% to 61.17% in commit 12a3233. Key findings:
Why 90% is not achievable with standard unit tests:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Deeply investigate solutions to increase code coverage over 80%. |
… coverage 61.4% Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Investigated extensively in commit c198005. Current coverage: 61.40% (525/855 lines). Why 80% is not achievable:
The 61.4% coverage represents all functional code paths reachable through normal API usage. The remaining code is defensive error handling. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Coverage Investigation for 80% Target
After extensive investigation, the current coverage is 61.40% (525 lines covered, 330 uncovered).
Uncovered Lines Breakdown:
Why 80% Coverage Cannot Be Achieved:
Total uncovered: 330 lines
Required for 80%: 684 lines (currently 525)
Gap: 159 lines
The remaining 330 uncovered lines consist of:
Error handling paths (~298 lines, 90% of uncovered):
mallocfails or memory limits are exceededCudd_SetMaxMemorydoesn't reliably trigger these paths because:Timeout handler lines (6 lines):
dd->timeoutHandlercallbackSpecial case
vf < vgin cuddZddWeakDivF (~26 lines):v == top_f && vf < vgwherevf = top_f >> 1andvg = top_g >> 1Conclusion:
The 61.4% coverage represents all achievable functional code paths without:
The remaining ~39% is defensive error handling code that provides robustness but cannot be tested through normal API usage.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.