Skip to content

fix: re-download bulk file if an empty temp file exists #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfourtythree merged 2 commits into from
Nov 17, 2025
Merged

fix: re-download bulk file if an empty temp file exists #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80443c7
fix: re-download bulk file if an empty temp file exists
astuteo Nov 12, 2025
7ce872a
Tweak
nfourtythree Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/jobs/ProcessBulkOperationData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,18 @@ protected function loadData(): Batchable
$this->tempFilePath = Assets::tempFilePath('jsonl');
}

$fileExists = file_exists($this->tempFilePath);
$fileSize = $fileExists ? filesize($this->tempFilePath) : 0;

// If somehow a zero-byte file exists, remove it to force a re-download
if ($fileExists && $fileSize === 0) {
FileHelper::unlink($this->tempFilePath);
$fileExists = false;
}

// Only re-download if the file doesn't already exist
// If the queue is using multiple workers and the file leaks between them,
if (!file_exists($this->tempFilePath)) {
if (!$fileExists) {
// Retrieve remote file contents
$client = Craft::createGuzzleClient();
$response = $client->get($this->dataUrl);
Expand Down
Loading