Skip to content

Conversation

@astuteo
Copy link
Contributor

@astuteo astuteo commented Nov 12, 2025

Description

Prevents a zero-byte temp file from blocking re-download of Shopify bulk data.

If a previous attempt left a 0-byte file at $this->tempFilePath, it now gets removed before the existence check, allowing a fresh download.

This resolves cases where the job would hang and constantly recycle "Processing bulk operation data..." in the queue without ever completing the job

@astuteo astuteo requested a review from a team as a code owner November 12, 2025 17:51
@nfourtythree nfourtythree self-assigned this Nov 17, 2025
@nfourtythree
Copy link
Contributor

Hi @astuteo

Thank you for your PR. Although we haven't seen this issue reported before this certainly would solve the issue that could occur.

Will get this merged and in a upcoming release.

To get this early, change your craftcms/shopify requirement in your project's composer.json to:

"require": {
  "craftcms/shopify": "6.x-dev as 6.1.1",
  "...": "..."
}

Then run composer update.

Thanks!

@nfourtythree nfourtythree merged commit a31f3ac into craftcms:6.x Nov 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants