-
Notifications
You must be signed in to change notification settings - Fork 664
C# release changes for cargo release
#3648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jdetter
wants to merge
17
commits into
master
Choose a base branch
from
jdetter/csharp-release-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0e8c87a
Changes for `cargo release`
jdetter a1e9f8c
Improve CI check
jdetter a6f68ca
Ignore meta files
jdetter 05b5f60
Merge branch 'master' into jdetter/csharp-release-changes
jdetter 6f28b3e
Update sdks/csharp/release~/spacetimedb.bsatn.runtime/unversioned/.gi…
jdetter 8c2472d
Update sdks/csharp/release~/.gitignore
jdetter 57a5531
Remove old package
jdetter 48ccf41
Merge branch 'jdetter/csharp-release-changes' of ssh://github.com/clo…
jdetter fe4d9e9
Moved packages under release~
jdetter 390211e
Merge branch 'master' into jdetter/csharp-release-changes
jdetter a0541ac
Merge tag 'v1.11.0' into jdetter/csharp-release-changes
jdetter ac7744f
Move gitignore file
jdetter d3114c3
Remove unused gitignore file
jdetter ae2a3f7
Update typescript package size limits (#3854)
jdetter bbfa851
Release v1.11.1
jdetter 8fbd9ac
Merge tag 'v1.11.1' into jdetter/csharp-release-changes
jdetter ff52259
Update .gitignore
jdetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| release~ |
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-73.5 KB
...ackages/spacetimedb.bsatn.runtime/1.5.0/analyzers/dotnet/cs/SpacetimeDB.BSATN.Codegen.dll
Binary file not shown.
Binary file removed
BIN
-67 KB
...packages/spacetimedb.bsatn.runtime/1.5.0/lib/netstandard2.1/SpacetimeDB.BSATN.Runtime.dll
Binary file not shown.
File renamed without changes.
File renamed without changes.
File renamed without changes.
11 changes: 11 additions & 0 deletions
11
sdks/csharp/release~/packages/spacetimedb.bsatn.runtime/unversioned/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # These files end up in the output directory from `dotnet pack`. We need to gitignore them | ||
| # otherwise we'll commit them to the Unity repository with no .meta files which causes | ||
| # warnings and sometimes build errors. | ||
| .nupkg.metadata | ||
| .signature.p7s | ||
| LICENSE | ||
| README.md | ||
| logo.png | ||
| spacetimedb.bsatn.runtime.*.nupkg* | ||
| spacetimedb.bsatn.runtime.nuspec | ||
| *.xml | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an aside.. to we expect any of these files to actually appear down here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they do appear due to
dotnet restore. Essentially these files end up in thepackages/spacetimedb.bsatn.runtime/vX.Y.Zdirectory. During the csharp release we copy the unversioned directory on top of the directory that contains these files.Right now when we do the C# release we are just doing a
git addon thepackagesdirectory, we could manuallygit addeach individual file instead but I think it's possible that might be more fragile? I'm not sure, I'm not highly invested into either approach here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that makes sense. Can we add something like this as a comment?
(that said, I'm surprised that things like
LICENSE,logo.png, andREADME.mdshow up.. but it also doesn't matter too much)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the LICENSE, logo.png and README.md files show up because of how dotnet pack works, for some reason those files are included when packing 🤷 .