C# release changes for cargo release
#3648
Conversation
jdetter
force-pushed
the
jdetter/csharp-release-changes
branch
from
13dd2c8 to
f514b08
Compare
|
Some missing or dangling .meta found. Fix commits are needed.
|
jdetter
force-pushed
the
jdetter/csharp-release-changes
branch
from
f514b08 to
909a8fc
Compare
|
Some missing or dangling .meta found. Fix commits are needed.
|
jdetter
force-pushed
the
jdetter/csharp-release-changes
branch
from
2bebcd4 to
0e8c87a
Compare
|
Some missing or dangling .meta found. Fix commits are needed.
|
|
Some missing or dangling .meta found. Fix commits are needed.
|
sdks/csharp/release~/spacetimedb.bsatn.runtime/unversioned/.gitignore
Outdated
Show resolved
Hide resolved
…tignore Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
Can you also remove the files from sdks/csharp/packages? They are stale since we're no longer updating them, and then I believe many of these files will show up as moved.
Also, I think we should probably gitignore them, so that devs iterating locally on sdks/csharp will not constantly have dirty working directories.
| logo.png | ||
| spacetimedb.bsatn.runtime.*.nupkg* | ||
| spacetimedb.bsatn.runtime.nuspec | ||
| *.xml |
There was a problem hiding this comment.
as an aside.. to we expect any of these files to actually appear down here?
There was a problem hiding this comment.
they do appear due to dotnet restore. Essentially these files end up in the packages/spacetimedb.bsatn.runtime/vX.Y.Z directory. During the csharp release we copy the unversioned directory on top of the directory that contains these files.
Right now when we do the C# release we are just doing a git add on the packages directory, we could manually git add each individual file instead but I think it's possible that might be more fragile? I'm not sure, I'm not highly invested into either approach here.
There was a problem hiding this comment.
ah that makes sense. Can we add something like this as a comment?
(that said, I'm surprised that things like LICENSE, logo.png, and README.md show up.. but it also doesn't matter too much)
There was a problem hiding this comment.
I think the LICENSE, logo.png and README.md files show up because of how dotnet pack works, for some reason those files are included when packing 🤷 .
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
…ckworklabs/SpacetimeDB into jdetter/csharp-release-changes
|
@bfops I removed everything under |
|
Some missing or dangling .meta found. Fix commits are needed.
|
# Description of Changes <!-- Please describe your change, mention any related tickets, and so on here. --> Updated package sizes from a failed release dry-run: https://github.com/clockworklabs/SpacetimeDBPrivate/actions/runs/20045893743/job/57491806595 # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> None # Expected complexity level and risk 1 - this is just a release fix <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> I have not tested this, it is a trivial change.
| "name": "sdk esm min (uncompressed)", | ||
| "path": "dist/min/sdk/index.browser.mjs", | ||
| "limit": "14 kB" | ||
| "limit": "30 kB" |
There was a problem hiding this comment.
unrelated? maybe a merge of master will fix this?
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
This LGTM, minus my two comments
There was a problem hiding this comment.
Actually, one other question - have you thought about the flow for devs making modifications to the Unity SDK? Does it still work smoothly?
My assumption would be that they end up with a version directly that keeps wanting to be added to git, so maybe we should gitignore any versioned directories, and temporarily remove that .gitignore file when we're doing the release?
I do want to make sure we don't make a bad flow for devs doing Unity SDK things, even if we don't do all of it in this PR. We may want an extra README and/or script to help facilitate the meta file copying.
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Description of Changes
This adds the new "skeleton" directory that we use for
cargo release.API and ABI breaking changes
None
Expected complexity level and risk
1 - this is just a release change
Testing
1.8.0and1.9.0release and we'll also be using it for the1.10.0release.