-
Notifications
You must be signed in to change notification settings - Fork 10
API cleanup #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API cleanup #46
Conversation
use recommended bitcoin_hashes
b98e1f4 to
1361a7c
Compare
|
@reez I'm going to need your help figuring out how to test the FFI bindings with Swift to exercise the new |
Reduce returned command data to just what is needed instead of entire response message.
1361a7c to
5a921da
Compare
Cool, let's take a look at this together tomorrow! |
|
Tested local bindings and made |
|
I also had some success today and got my Swift test working with a custom CkTransport that talks to a locally running card emulator. So now I should be able to move on to adding the rest of the APIs to the ffi bindings. |
|
Got SATSCARD sign and sign_psbt functions working with emulator unit test and with a real card on mainnet. I used cc: @praveenperera |
26bde07 to
84a73aa
Compare
3054c4a to
dedd262
Compare
Also make all apdu types crate(pub) instead of pub.
dedd262 to
ec6228c
Compare
9f00481 to
459c596
Compare
Fixed doc error with ref URLs.
3c064f9 to
759d65e
Compare
b51b7bd to
f0eb0f1
Compare
|
I should be all done with refactoring and exposing all implemented card commands via ffi. The |
0ad90c4 to
c0f1c68
Compare
Also update README completed commands.
c0f1c68 to
4694844
Compare
Description
Notes to the reviewers
The original purpose of this was to simplify the API as much as possible by only returning required data from commands instead of the entire APDU message which contains fields only needed for validation or to update the nonce. Along the way I realized the generics can be removed which makes the FFI bindings easier to do and generally simplifies the code. I also cleaned up some other warnings and dependencies.
I added lib
signandsign_psbtcommands forSatsCardand refactored errors for all commands to be more tailored to what could actually go wrong. I also added "sign <psbt>" and "dump <slot>" commands to the cli for SatsCard, and exposed all lib commands and errors in the FFI bindings.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: