Skip to content

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 31, 2025

Description

Add support for the 'nfc' and 'xpub' commands in the lib, cli, and ffi bindings. Updates cli sign for TAPSIGNER and SATSCHIP to sign a PSBT instead of a message.

Closes: #16
Closes: #17

Notes to the reviewers

This is based on #46 and I'll rebase after that PR is merged.

Changelog notice

  • Add support for nfc and xpub commands in the lib, cli, and ffi bindings.
  • Change cli sign command for TAPSIGNER and SATSCHIP to sign a PSBT instead of a digest.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory notmandatory self-assigned this Aug 31, 2025
@notmandatory notmandatory added the enhancement New feature or request label Aug 31, 2025
@notmandatory notmandatory changed the title Add support for 'nfc' command Add support for 'nfc' and 'xpub' commands Aug 31, 2025
@notmandatory notmandatory marked this pull request as ready for review September 1, 2025 16:02
@notmandatory notmandatory merged commit c9826bd into master Sep 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commands to implement for the rust-cktap lib Commands to implement for the cktap-cli

2 participants