Properly sequence logging effects in S3Writer

[Copilot]

Log statements in createS3Client and ensureBucket were executed within Async[F].delay blocks, causing their F[Unit] effects to be discarded rather than sequenced.

Changes

• createS3Client: Replaced single delay block with for-comprehension to sequence client creation and logging
• ensureBucket: Refactored to use flatMap pattern, returning Either from bucket check then properly sequencing all log statements

Example

Before (logging effect discarded):

Async[F].delay {
  val client = createClient()
  log.info("Client created")  // F[Unit] discarded
  client
}

After (logging effect sequenced):

for {
  client <- Async[F].delay(createClient())
  _ <- log.info("Client created")  // F[Unit] properly sequenced
} yield client

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.