move to cats logger #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akreit
force-pushed
the
copilot/build-etl-pipeline-scala
branch
from
5b70a60 to
afbbbd6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the logging implementation from LazyLogging (typesafe scala-logging) to log4cats, a functional logging library that integrates with the Cats Effect ecosystem. The changes make logging effectful and polymorphic over effect types.
Key changes:
- Refactored
CatsLoggertrait to provide a polymorphic logger method instead of a fixedIO-based logger - Updated all components (
S3Writer,EtlPipeline,Main) to use effectful logging vialog4cats - Simplified
DataRepositoryto a function-based implementation and added doobie derivation forSampleData
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/scala/com/async2databricks/utils/CatsLogger.scala |
Changed from IO-specific logger to polymorphic logger supporting any effect type with Sync |
src/main/scala/com/async2databricks/s3/S3Writer.scala |
Replaced LazyLogging with CatsLogger; made methods polymorphic; converted side-effecting logs to effectful operations |
src/main/scala/com/async2databricks/model/SampleData.scala |
Added doobie Read and Write derivation and necessary imports |
src/main/scala/com/async2databricks/etl/EtlPipeline.scala |
Replaced LazyLogging with CatsLogger; refactored to use effectful logging throughout |
src/main/scala/com/async2databricks/database/DataRepository.scala |
Simplified to function-based implementation; removed custom Read instance (now derived); removed unused imports |
src/main/scala/com/async2databricks/Main.scala |
Updated to obtain logger instance explicitly for IO effect type |
project/plugins.sbt |
Downgraded sbt-scoverage plugin version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/scala/com/async2databricks/database/DataRepository.scala
Outdated
Show resolved
Hide resolved
Contributor
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Co-authored-by: akreit <64101884+akreit@users.noreply.github.com>
…ambda Co-authored-by: akreit <64101884+akreit@users.noreply.github.com>
Fix DataRepository to return trait implementation instead of lambda
Properly sequence logging effects in S3Writer
Contributor
Co-authored-by: akreit <64101884+akreit@users.noreply.github.com>
Restore ETL pipeline completion log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.