Skip to content

GeoJSON implementation fixes #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvl22 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

GeoJSON implementation fixes #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3757025
In GeoJSON, fix feature_collection validation
mvl22 Apr 10, 2018
6783cd2
In GeoJSON, enable LineString and Polygon to pass through validate_fe…
mvl22 Apr 10, 2018
0d264ba
Fix coordinates in GeoJSON example - GeoJSON order is lng,lat
mvl22 Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,20 +126,20 @@ map_configuration = {
urls: ['http://a.tile.thunderforest.com/transport/${z}/${x}/${y}.png'], # currently only one is being used, in the future it will load balance
level: 1, # used to order the layer appearance
opacity: 1.0 # in case you want the layer to have some transparency
}], # see geojson specification for feature/object support. See http://leafletjs.com/reference.html#path-options for formatting options, the following attributes under properties are supported: `stroke, color, weight, opacity, fill, fillColor, fillOpacity, fillRule, dashArray, lineCap, lineJoin`
}], # see GeoJSON specification for feature/object support. See http://leafletjs.com/reference.html#path-options for formatting options, the following attributes under properties are supported: `stroke, color, weight, opacity, fill, fillColor, fillOpacity, fillRule, dashArray, lineCap, lineJoin`
geojson: '{
"type": "FeatureCollection",
"features": [{
"type":"Feature",
"geometry":{"type":"Point", "coordinates":[-32.026862,-55.425003]},
"geometry":{"type":"Point", "coordinates":[-55.425003,-32.026862]},
"properties":{"image": "./marker.png"}
}, {
"type": "Feature",
"geometry": {"type": "LineString", "coordinates": [ [-32.026862,-55.425003], [-31.026862,-55.425003], [-31.026862,-54.425003], [-32.026862,-54.425003] ] },
"geometry": {"type": "LineString", "coordinates": [ [-55.425003,-32.026862], [-55.425003,-31.026862], [-54.425003,-31.026862], [-54.425003,-32.026862] ] },
"properties": {"color": "#000000"}
}, {
"type": "Feature",
"geometry": {"type": "Polygon", "coordinates": [ [-32.126862,-55.825003], [-31.426862,-55.225003], [-31.326862,-54.825003], [-32.146862,-54.835003] ] },
"geometry": {"type": "Polygon", "coordinates": [ [-55.825003,-32.126862], [-55.225003,-31.426862], [-54.825003,-31.326862], [-54.835003,-32.146862] ] },
"properties": {
"stroke": true,
"color": "#000000",
Expand Down
4 changes: 3 additions & 1 deletion lib/map_print/geo_json_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def draw_geojson
def validate_feature(geometry, properties)
raise NoGeometryPresent.new("No geometry present for this feature") if geometry.nil?
case geometry['type']
when 'LineString', 'Polygon'
# No checks needed
when 'Point'
if properties.nil? || properties['image'].nil?
raise NoPointImage.new("Missing image in point geometry")
Expand Down Expand Up @@ -72,7 +74,7 @@ def feature(geometry, properties={})

def feature_collection(features)
features.each do |object|
feature(object)
feature(object['geometry'], object['properties'])
end
end

Expand Down