GeoJSON implementation fixes #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@afast I release these contributions under the MIT License (MIT) and as public domain. |
Owner
|
Thanks for making the effort of a contribution! |
Author
As a standalone executable - trying to generate a PDF of a map with GeoJSON. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Fixes the validation in feature_collection(), where feature() was being passed the whole feature, but expects a geometry and properties instead.
Enables LineString and Polygon to work - validate_feature() had no case for these, resulting in Feature type not implemented always being thrown.
Fixes the GeoJSON example so that it produces a working result - the co-ordinate pairs were the wrong way round.