-
Notifications
You must be signed in to change notification settings - Fork 70
Ensure Time dim is added to landice initial condition #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MPAS meshes include an empty, unlimited `Time` dimension but the latest NetCDF4 drops this dimension since no variable use it. the `create_from_generic_mpas_grid()` funciton in `landice.create` was taking advantage of `Time` being a dimension in the MPAS mesh but this should no longer be assumed. This merge fixes that assumption by explicitly adding `Time` to the list of dimensions to create if it is not already in the input dataset.
|
@matthewhoffman and @trhille, a new version of JIGSAW was released last week: In the process of testing it, I learned that new newest version of I didn't do any MALI testing that that has proven to be a dumb move. MALI breaks for a different reason. There has also been an update to NetCDF4: Note: MPAS-Tools lints and formats any files that we change using |
matthewhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar , thank you for taking care of this. I imagine it was a lot of work to untangle the new issues with xarray and netcdf4. I reviewed the first commit by inspection and it makes sense to me.
MPAS meshes include an empty, unlimited
Timedimension but the latestNetCDF4drops this dimension since no variable use it. Thecreate_from_generic_mpas_grid()funciton inlandice.createwas taking advantage ofTimebeing a dimension in the MPAS mesh but this should no longer be assumed. This PR fixes that assumption by explicitly addingTimeto the list of dimensions to create if it is not already in the input dataset.