Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Aug 17, 2025

This version updates:

  • mpas_tools to 1.3.1 -- brings in:
    • some improvements and fixes to build_jigsaw
    • a fix to write_netcdf() to handle a problem in the latest xarray (2025.8.0) when unlimited dimensions are sliced.
    • fixes an issue with missing Time dimension when creating MALI initial conditions
  • jigsaw and jigsaw-python to 1.1.0 -- includes threading with OpenMP

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented Aug 17, 2025

Testing

I successfully ran the ocean pr suite on Chrysalis with these changes. Since I expect the new JIGSAW version to change meshes, I didn't try to compare with previous pr runs.

I also ran the land-ice full_integration suite on Chrysalis with the new JIGSAW and MPAS-Tools. Unfortunately, I'm seeing a bunch of NetCDF4-related errors that I need to debug.

@xylar xylar marked this pull request as draft August 18, 2025 09:20
@xylar
Copy link
Collaborator Author

xylar commented Aug 18, 2025

The MALI full_integration suite runs successfully on Chrysalis with the fix from MPAS-Dev/MPAS-Tools#664. We'll need a new 1.3.1 release of MPAS-Tools to bring this in.

@xylar xylar force-pushed the update-to-mpas-tools-1.3.0 branch from c80f515 to 7965b24 Compare August 19, 2025 11:10
@xylar xylar marked this pull request as ready for review August 19, 2025 11:24
@xylar
Copy link
Collaborator Author

xylar commented Aug 19, 2025

Further testing

I reran the full_integration suite with MPAS-Tools 1.3.1 and it works:

/lcrc/group/e3sm/ac.xylar/compass_1.8/chrysalis/test_20250819/full_integ_1.8.0-alpha.2

@xylar
Copy link
Collaborator Author

xylar commented Aug 19, 2025

@matthewhoffman and @trhille, if you could test this out on a more recent MALI-Dev than the Compass submodule and also check if generating a variable resolution mesh with the new JIGSAW works as expected for you, that would be great.

Without these fixes, any new Compass environment is likely to result in failures.

@xylar xylar self-assigned this Aug 19, 2025
@xylar xylar added the dependencies Pull requests that update a dependency file label Aug 19, 2025
Copy link
Member

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

I confirmed that I can build MALI with this env and that the landice full_integration suite passes. I then set up and ran the koge_bugt_s/mesh_gen mesh gen case and it passes.

The mesh generated with this PR (bottom) differs in cell layout from one generated with 1.8.0-alpha.1 (top), including an uglier disconnected region, but I attribute that just to a different random realization of JIGSAW associated with the version of that code changing and not a problem.

image

@xylar xylar merged commit 52b6a6c into MPAS-Dev:main Aug 19, 2025
6 checks passed
@xylar xylar deleted the update-to-mpas-tools-1.3.0 branch August 19, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants