Skip to content

Conversation

@SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Dec 17, 2025

Description

During the build, the following warning is reported:

err: #13 83.68 DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
err: #13 83.68 
err: #13 83.68 More info and automated migrator: https://sass-lang.com/d/import
err: #13 83.68 
err: #13 83.68    ╷
err: #13 83.68 16 │ @import '@assets/mixin.scss';
err: #13 83.68    │         ^^^^^^^^^^^^^^^^^^^^
err: #13 83.68    ╵

This PR updates SCSS files to use @use instead of @import to remove the warning.

Note:
@use adds a namespace by default. In this PR, I used as * to load the module without a namespace.
More info can be found here.

Reference:

Jira link: https://lite-farm.atlassian.net/browse/LF-5095

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno self-assigned this Dec 17, 2025
@SayakaOno SayakaOno closed this Dec 17, 2025
@SayakaOno SayakaOno changed the title [WIP] LF-5095: Migrate SCSS from @import to @use LF-5095: Migrate SCSS from @import to @use Dec 17, 2025
@SayakaOno SayakaOno reopened this Dec 17, 2025
@SayakaOno SayakaOno marked this pull request as ready for review December 18, 2025 17:24
@SayakaOno SayakaOno requested review from a team as code owners December 18, 2025 17:24
@SayakaOno SayakaOno requested review from kathyavini and removed request for a team December 18, 2025 17:24
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍😍😍😍

I don't even know how long I've been used to that flood of errors in the webapp console. Amazing, thank you!!! The SCSS linting is nice too!

It kind of makes me want to hide the 'legacy-js-api' warnings too now, as they are all we have left. I don't think a Vite upgrade is in our immediate future.

Edit: oh, I just saw belatedly the 'legacy-js-api' was mentioned in the Jira ticket for this one. That's not expected to be fixed by this change though, right? I think we have to actively silence that one. I'll open the trivial PR.

@kathyavini kathyavini added this pull request to the merge queue Dec 18, 2025
Merged via the queue into integration with commit 29fdc68 Dec 18, 2025
8 of 9 checks passed
@SayakaOno SayakaOno deleted the LF-5095/Migrate_SCSS_from_@import_to_@use branch December 18, 2025 21:02
@SayakaOno
Copy link
Collaborator Author

SayakaOno commented Dec 18, 2025

Oh, yes! I found out after creating the ticket that it isn’t possible to remove the legacy-js-api warnings at this point!! (without silencing it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants