Skip to content

Conversation

@kathyavini
Copy link
Collaborator

Description

After the torrent of SCSS warnings in the webapp console / build process were resolved in:

There is now just the singular warning

Screenshot 2025-12-18 at 11 38 37 AM

According to the provided link https://sass-lang.com/d/legacy-js-api the new API is supported by default in Vite 6 and as an option in Vite 5.4+. We are on Vite 4. Although we will need to upgrade at some point, this SASS deprecation will not the impetus/cause, so I am silencing it for now.

Jira link: https://lite-farm.atlassian.net/browse/LF-5098

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Webapp console inspected

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini self-assigned this Dec 18, 2025
@kathyavini kathyavini requested review from a team as code owners December 18, 2025 19:45
@kathyavini kathyavini requested review from Duncan-Brain and removed request for a team December 18, 2025 19:45
@Duncan-Brain
Copy link
Collaborator

Cool if I tag in @SayakaOno here? I personally prefer to keep warnings until resolved.

@SayakaOno
Copy link
Collaborator

I don’t mind the warning, but I’m also okay with silencing it for now, as long as we remember to clean up the config when upgrading to Vite 6! 😄

@kathyavini
Copy link
Collaborator Author

I personally prefer to keep warnings until resolved.

@Duncan-Brain that makes sense if it's a reminder of something we need to address (e.g. the Google Maps deprecations), but there isn't a todo on this one other than upgrading Vite. And we aren't going to upgrade Vite on account of this warning, so it's just console noise until then.

@Duncan-Brain Duncan-Brain removed their request for review December 19, 2025 13:50
@Duncan-Brain
Copy link
Collaborator

I only care enough to have my small nothing opinion haha, so it seems like Sayaka is okay with it! Great merge it!

And I think my opinion still makes sense. The annoying thing is a small indicator we are out of date on a major thing -- keeping it noisy is meant to pester you until you do the right thing -- even if its not a "good reason". I have never silenced warnings before 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants