Skip to content

feat: Define "extra" optional dependencies with ml, starting with ins… #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deependra-Patel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Define "extra" optional dependencies with ml, starting with ins… #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,7 @@
"tqdm>=4.67",
"websockets>=14.0",
],
extras_require={
"ml": ["dataproc-ml>=1.0.0-rc1,<=1.0"],
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version specifier for dataproc-ml is very restrictive. The upper bound <=1.0 will prevent users from installing patch releases (e.g., 1.0.1) which may contain important bug fixes. It's better to allow for compatible future releases by specifying a more flexible upper bound for the version. Using <1.1 would allow for all 1.0.x releases, which is a common and recommended practice for libraries that follow semantic versioning.

Suggested change
"ml": ["dataproc-ml>=1.0.0-rc1,<=1.0"],
"ml": ["dataproc-ml>=1.0.0-rc1,<1.1"],

Copy link
Contributor

@medb medb Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to adhere to semver for dataproc-ml? I.e. will 1.1 have backward compatibility with 1.0?

Copy link
Contributor

@medb medb Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to add other deps that we need to match between client and server. For example we had issues w/ numpy, is there anything else that we care about? cc @jayadeep-jayaraman

},
)
Loading