-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Define "extra" optional dependencies with ml, starting with ins… #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…talling dataproc-ml
Summary of ChangesHello @Deependra-Patel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's dependency management by adding an optional Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an 'ml' extra for optional dependencies, starting with dataproc-ml. While the addition is a good feature, the version specifier for dataproc-ml is overly restrictive. My feedback includes a suggestion to adjust the version constraint to allow for future patch releases, which will prevent potential dependency issues for users and allow them to receive bug fixes without requiring a new release of this package.
| "websockets>=14.0", | ||
| ], | ||
| extras_require={ | ||
| "ml": ["dataproc-ml>=1.0.0-rc1,<=1.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version specifier for dataproc-ml is very restrictive. The upper bound <=1.0 will prevent users from installing patch releases (e.g., 1.0.1) which may contain important bug fixes. It's better to allow for compatible future releases by specifying a more flexible upper bound for the version. Using <1.1 would allow for all 1.0.x releases, which is a common and recommended practice for libraries that follow semantic versioning.
| "ml": ["dataproc-ml>=1.0.0-rc1,<=1.0"], | |
| "ml": ["dataproc-ml>=1.0.0-rc1,<1.1"], |
…talling dataproc-ml