-
Notifications
You must be signed in to change notification settings - Fork 2
feat: added eval reasons to variable properties #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6ecf03e
feat: added eval reasons to variable properties
jsalaber f3c7428
chore: add eval reason capability to ruby
jsalaber ebe0e9f
chore: update bucketing lib and use correct eval reasons
jsalaber 21eb47e
chore: attempt to debug failing harness tests
jsalaber de856e4
chore: fix _feature being returned in allVariables
jsalaber 94f4927
fix: filter out _feature in allVariables return
jsalaber 704179e
chore: add eval reason to agg_variable_defaulted metadata
jsalaber ff845c1
chore: update bucketing lib for events eval reasons
jsalaber 96e2c90
chore: added default reason to event metadata
jsalaber 9607745
chore: removed unused reasons and details
jsalaber 2d70749
chore: try to run cloud for ruby test harness
jsalaber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| module DevCycle | ||
| # Evaluation reasons for successful evaluations | ||
| module EVAL_REASONS | ||
| DEFAULT = 'DEFAULT' | ||
| ERROR = 'ERROR' | ||
| end | ||
|
|
||
| # Default reason details | ||
| module DEFAULT_REASON_DETAILS | ||
| MISSING_CONFIG = 'Missing Config' | ||
| USER_NOT_TARGETED = 'User Not Targeted' | ||
| end | ||
| end | ||
Binary file modified
BIN
+7.38 KB
(100%)
lib/devcycle-ruby-server-sdk/localbucketing/bucketing-lib.release.wasm
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 25 additions & 59 deletions
84
lib/devcycle-ruby-server-sdk/localbucketing/proto/variableForUserParams_pb.rb
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #!/bin/bash | ||
| BUCKETING_LIB_VERSION="1.35.1" | ||
| BUCKETING_LIB_VERSION="1.41.0" | ||
| WAT_DOWNLOAD=0 | ||
| rm bucketing-lib.release.wasm | ||
| wget "https://unpkg.com/@devcycle/bucketing-assembly-script@$BUCKETING_LIB_VERSION/build/bucketing-lib.release.wasm" | ||
| wget "https://unpkg.com/@devcycle/bucketing-assembly-script@$BUCKETING_LIB_VERSION/build/bucketing-lib.release.wasm" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.