Skip to content

feat: added eval reasons to variable properties #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsalaber merged 11 commits into from
Jul 28, 2025
Merged

feat: added eval reasons to variable properties #122

jsalaber merged 11 commits into from
Jul 28, 2025

Conversation

@jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Jul 22, 2025 •
edited
Loading

Changes

  • added eval reasons and updated bucketing lib
  • added temporary capabilities in test harness yml:
"evalReason", "cloudEvalReason", "eventsEvalReason", "variablesFeatureId"

@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from 3f09191 to b59c8b6 Compare July 22, 2025 21:02
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch 3 times, most recently from 85c7215 to b4d4387 Compare July 23, 2025 18:27
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from b4d4387 to f3c7428 Compare July 23, 2025 18:41
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch 3 times, most recently from 49c8c0c to 9314d34 Compare July 25, 2025 16:09
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from 9314d34 to 21eb47e Compare July 25, 2025 16:46
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from 5e9b06b to 94f4927 Compare July 25, 2025 17:35
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from d32938b to 0831d6f Compare July 25, 2025 18:35
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from 0831d6f to 96e2c90 Compare July 25, 2025 18:42
@jsalaber jsalaber marked this pull request as ready for review July 25, 2025 19:03
@jsalaber jsalaber requested a review from a team as a code owner July 25, 2025 19:03
@jsalaber jsalaber requested a review from a team July 25, 2025 19:15
kaushalkapasi
kaushalkapasi reviewed Jul 28, 2025
View reviewed changes
kaushalkapasi
kaushalkapasi reviewed Jul 28, 2025
View reviewed changes
kaushalkapasi
kaushalkapasi reviewed Jul 28, 2025
View reviewed changes
kaushalkapasi
kaushalkapasi reviewed Jul 28, 2025
View reviewed changes
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from 3caa487 to a981275 Compare July 28, 2025 14:45
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch 2 times, most recently from 0e7cac6 to 3562261 Compare July 28, 2025 15:09
@jsalaber jsalaber requested a review from phaym July 28, 2025 15:22
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from 3562261 to eaf75c5 Compare July 28, 2025 15:23
@jsalaber jsalaber requested a review from kaushalkapasi July 28, 2025 17:32
kaushalkapasi
kaushalkapasi reviewed Jul 28, 2025
View reviewed changes
@jsalaber jsalaber force-pushed the COR-3471-ruby-eval-reasons branch from eaf75c5 to 2d70749 Compare July 28, 2025 20:15
@jsalaber jsalaber merged commit 6482918 into main Jul 28, 2025
8 checks passed
@jsalaber jsalaber deleted the COR-3471-ruby-eval-reasons branch July 28, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaushalkapasi kaushalkapasi kaushalkapasi approved these changes

@phaym phaym Awaiting requested review from phaym

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsalaber @phaym @kaushalkapasi