-
Notifications
You must be signed in to change notification settings - Fork 166
fix(CI): resolve flaky tests #3560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3560 +/- ##
==========================================
+ Coverage 61.81% 61.90% +0.09%
==========================================
Files 140 140
Lines 13281 13281
Branches 1758 1758
==========================================
+ Hits 8209 8221 +12
+ Misses 4282 4272 -10
+ Partials 790 788 -2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2026-01-13 10:50:17 Comparing candidate commit 88ce401 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics. |
a8dc442 to
34a1dec
Compare
34a1dec to
9648227
Compare
… before starting kafka Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
9648227 to
88ce401
Compare
|
This PR addresses several recurring flaky tests.
1. Kafka Integration Tests - Race Condition
Issue:
Kafka and Zookeeper start in parallel. Kafka attempts to connect before Zookeeper completes initialization.
Fix:
.gitlab/generate-common.php: Added Zookeeper readiness check to Kafka entrypoint (waits forruok/imokresponse).gitlab/wait-for-service-ready.sh: Added Zookeeper service detection and native health check, increased Kafka settle time2. CentOS Package Verification - Yum Timeouts
Issue:
verify centosfailing with "Exiting on user cancel" - actually yum's 30-second stalled download timeout. Retries happened immediately, hitting same network issues.Fix:
dockerfiles/verify_packages/centos/install.sh: Increased yum timeout to 300s, added 5-second delay between retries3. Profiling Tests - PHP 7.X jit allocation
Issue:
allocation_jit_01.phptfailing on PHP 7.X versions even tho jit feature is available for 8.0+ versions.Fix:
profiling/tests/phpt/allocation_jit_01.phpt: Added skip condition for PHP < 8.0 (consistent with other JIT tests)4. Extension CI Tests - Valgrind Timeouts
Issue:
agent_sampling-standalone-asm_*.phpttiming out during valgrind run (second pass with memory checking). Valgrind causes slowdown which is enough to hit PHP 60s test timeout.Fix:
tests/ext/background-sender/agent_sampling-standalone-asm_*.phpt: IncreasedmaxIterationand loop number of iterations