-
Notifications
You must be signed in to change notification settings - Fork 166
fix(prof): use cached heap in alloc_prof_orig_* functions
#3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3547 +/- ##
==========================================
- Coverage 62.05% 62.01% -0.05%
==========================================
Files 140 140
Lines 13309 13309
Branches 1762 1762
==========================================
- Hits 8259 8253 -6
- Misses 4262 4268 +6
Partials 788 788 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2026-01-14 10:45:16 Comparing candidate commit bbcaf45 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics. |
61be8bf to
446ec2d
Compare
|
13d44b8 to
b389c65
Compare
A crash report indicated that `_zend_mm_alloc` was being called with an invalid heap pointer This invalid pointer originated from the call to `zend::zend_mm_get_heap()` within `alloc_prof_orig_alloc`.
b389c65 to
f2ddfd3
Compare
|
Let's wait for #3560 get merged and fix the flaky profiling test first |
Description
A crash report ...
... indicated that
_zend_mm_allocwas being called with an invalid heap pointer. This invalid pointer originated from the call tozend::zend_mm_get_heap()withinalloc_prof_orig_allocwhich is weird and can only mean that "something" changed the current heap viazend_mm_set_heap()after we installed our hooks inRINITto something invalid, but I could not find any other extension that are known for these kind of things in the crash report.So: In the end it is the right thing to call the heap that we registered our ZendMM custom handlers in.
Reviewer checklist