Allocate hex map with the trailing NULL #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilers usually warns or errors on such allocations. This would require special compiler parameter or attribute to silence it. Unfortunately, it is compiler specific, e.g. with gcc one could use "__attribute__ ((nonstring))" or with C23 just "[[nonstring]]" or gcc parameter "-Wno-error=unterminated-string-initialization". With other compilers it's different. So do not over-complicate things and allocate it just one more byte longer with the dummy NULL which should silence most of the compilers. It's static allocation, just one byte, the overhead should be negligible. Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
Author
|
Fedora recently switched to the gcc-15 with C23 as the default standard and tighten the checks, so without the patch it fails to compile with the default compiler settings, downstream Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2340611 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilers usually warns or errors on such allocations. This would require special compiler parameter or attribute to silence it. Unfortunately, it is compiler specific, e.g. with gcc one could use "attribute ((nonstring))" or with C23 just "[[nonstring]]" or gcc parameter
"-Wno-error=unterminated-string-initialization". With other compilers it's different. So do not over-complicate things and allocate it just one more byte longer with the dummy NULL which should silence most of the compilers. It's static allocation, just one byte, the overhead should be negligible.