Skip to content

hidrd: fix build with gcc15 #475642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Dec 31, 2025
Merged

hidrd: fix build with gcc15 #475642

Aleksanaa merged 1 commit into from
Dec 31, 2025

Conversation

@Moraxyc
Copy link
Member

@Moraxyc Moraxyc commented Dec 31, 2025

https://hydra.nixos.org/build/318031369
Apply the patch from DIGImend/hidrd#33

#475479

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 31, 2025
@Moraxyc
Copy link
Member Author

Moraxyc commented Dec 31, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 475642
Commit: ee8b4b4d201d39ca6a1f30e353fde37e0b82a5ff (subsequent changes)
Merge: 43cd2643b89cec7aa79ea8ebbe04b3244c62979f

Logs: https://github.com/Moraxyc/nixpkgs-review-gha/actions/runs/20622459249

x86_64-linux

✅ 2 packages built:
  • hidrd
  • iptsd

aarch64-linux

✅ 2 packages built:
  • hidrd
  • iptsd

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Moraxyc Moraxyc marked this pull request as ready for review December 31, 2025 16:08
@Aleksanaa
Copy link
Member

Aleksanaa commented Dec 31, 2025

https://github.com/NixOS/nixpkgs/tree/master/pkgs#patches

image

@nixpkgs-ci nixpkgs-ci bot requested a review from pacien December 31, 2025 16:17
@Moraxyc
Copy link
Member Author

Moraxyc commented Dec 31, 2025

master/pkgs#patches
image

Done. Vendored the patch.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Dec 31, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Dec 31, 2025
Merged via the queue into NixOS:master with commit a9f427d Dec 31, 2025
31 of 33 checks passed
@Moraxyc Moraxyc deleted the fix-hidrd-gcc15 branch January 1, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@pacien pacien Awaiting requested review from pacien

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Moraxyc @Aleksanaa