[lib][web][native] introduce olmSupportRequired and create session with based on code version
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with based on code version Summary: [ENG-11545](https://linear.app/comm/issue/ENG-11545/handle-olm-x3dh-bug). Assuming keyserver is going to be deployed first, and we have only one keyserver so by default, hardcoding `olmSupportRequired: false` for keyservers. This should be deprecated and in the future, each device should use vodozemac only. Depends on D15550 Test Plan: Test creating session when this return false (by default it was true). Reviewers: ashoat
|
|
Ashoat
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ENG-11545.
Assuming keyserver is going to be deployed first, and we have only one keyserver so by default, hardcoding
olmSupportRequired: falsefor keyservers.This should be deprecated, and in the future, each device should use Vodozemac only.
I think
NEXT_CODE_VERSIONis something that needs to be updated during the release process? (cc. @Ashoat)Depends on D15550
Test Plan: Test creating session when this returns false (by default it was true). Tested some basic features (notifs, DMs, register/restore)
Reviewers: ashoat