[lib] support E2EE DMs only for Vodozemac clients #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xsanm
force-pushed
the
support-dms-for-vodozemac-only
branch
from
c2a8620 to
49aee34
Compare
Summary: Solution #3 from [ENG-11545](https://linear.app/comm/issue/ENG-11545/handle-olm-x3dh-bug). I had to move `useGetDeviceListsForUsers` because of dependency cycle. Test Plan: Set `NEXT_CODE_VERSION` for something different and test what `useUsersSupportThickThreads` returns for devices during searching users Reviewers: ashoat
xsanm
force-pushed
the
support-dms-for-vodozemac-only
branch
from
49aee34 to
ce9e87d
Compare
Ashoat
approved these changes
Dec 4, 2025
| UsersDevicesPlatformDetails, | ||
| SignedDeviceList, | ||
| RawDeviceList, | ||
| SignedDeviceList, |
Member
There was a problem hiding this comment.
Concerning to see these moved around, makes me wonder if the prior PR would fail ESLint CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Solution 3 from ENG-11545.
Some context when to merge it in ENG-11554.
I had to move
useGetDeviceListsForUsersbecause of a dependency cycle.Test Plan: Set
NEXT_CODE_VERSIONfor something different and test whatuseUsersSupportThickThreadsreturns for devices during searching usersReviewers: ashoat
Needs to be rebased on #328