generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 353
Sheffield | September | Xiayidan Abudu | Sprint 1 | Wireframe #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shayida999
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
Shayida999:wireframe-completed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
16a6505
Complete wireframe task
Shayida999 50e50e1
Fix: moved wireframe code to Wireframe folder and deleted extra folder
Shayida999 2738289
Remove unwanted wireframe-task folder and files
Shayida999 da99ff4
ch
Shayida999 118bd81
Fix: remove arrow icons and unify first article font size
Shayida999 3e35c52
Fix form validation and remove <small> tags, add placeholders for cle…
Shayida999 df12af1
Remove Form-Controls file from Wireframe PR
Shayida999 da21e3b
Fix footer spacing so buttons are not hidden and update footer text
Shayida999 3f6143b
Fix footer spacing so buttons are not hidden and update footer text
Shayida999 5e4f747
Restore Form-Controls/index.html and update Wireframe
Shayida999 e53cd4f
Remove Form-Controls changes from Wireframe PR
Shayida999 de9a9c6
Fix article links for wireframe, git branch, and README
Shayida999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,158 @@ | ||
| /* Here are some starter styles | ||
| You can edit these or replace them entirely | ||
| It's showing you a common way to organise CSS | ||
| And includes solutions to common problems | ||
| As well as useful links to learn more */ | ||
|
|
||
| /* ====== Design Palette ====== | ||
| This is our "design palette". | ||
| It sets out the colours, fonts, styles etc to be used in this design | ||
| At work, a designer will give these to you based on the corporate brand, but while you are learning | ||
| You can design it yourself if you like | ||
| Inspect the starter design with Devtools | ||
| Click on the colour swatches to see what is happening | ||
| I've put some useful CSS you won't have learned yet | ||
| For you to explore and play with if you are interested | ||
| https://web.dev/articles/min-max-clamp | ||
| https://scrimba.com/learn-css-variables-c026 | ||
| ====== Design Palette ====== */ | ||
| :root { | ||
| --paper: oklch(7 0 0); | ||
| --paper: white; | ||
| --ink: color-mix(in oklab, var(--color) 5%, black); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| --line: 1px solid black; | ||
| --container: 1000px; | ||
| } | ||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
|
|
||
| html, body { | ||
| height: 100%; | ||
| margin: 0; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| background: linear-gradient(to right, #e0f7fa, #e1f5fe); | ||
| color: black; | ||
| font: var(--font); | ||
| min-height: 100vh; | ||
| } | ||
| a { | ||
|
|
||
| header { | ||
| text-align: center; | ||
| padding: var(--space) 0; | ||
| } | ||
|
|
||
| header hr { | ||
| border: none; | ||
| border-top: 1.5px solid black; | ||
| width: 55%; | ||
| } | ||
|
|
||
| header p { | ||
| margin-bottom: 0.2rem; | ||
| } | ||
|
|
||
| h2 { | ||
| font-family: 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif; | ||
| color: #333; | ||
| margin-top: 1rem; | ||
| margin-bottom: 0.5rem; | ||
| font-size: 24px; | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| h1:hover { | ||
| color: purple; | ||
| transition: color 0.3s ease; | ||
| } | ||
|
|
||
| h1 { | ||
| font-size: 2rem; | ||
| } | ||
|
|
||
|
|
||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| padding-bottom: 100px; | ||
| flex: 1; | ||
|
|
||
| } | ||
|
|
||
| main > *:first-child { | ||
| grid-column: span 2; | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| } | ||
|
|
||
| a { | ||
| padding: 6px 12px; | ||
| font-size: 0.85rem; | ||
| background-color: #007acc; | ||
| color: white; | ||
| text-decoration: none; | ||
| border-radius: 4px; | ||
| display: inline-flex; | ||
| align-items: center; | ||
| gap: 4px; | ||
| margin-top: var(--space); | ||
| max-width: fit-content; | ||
| transition: background-color 0.2s ease; | ||
| } | ||
|
|
||
|
|
||
| a:hover { | ||
| background-color: #005f99; | ||
| } | ||
|
|
||
| img, | ||
| svg { | ||
| width: 100%; | ||
| object-fit: cover; | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
|
|
||
| article { | ||
| box-shadow: 0 2px 8px rgba(0, 0, 0, 0.05); | ||
| border-radius: 8px; | ||
| padding-bottom: var(--space); | ||
| text-align: left; | ||
| padding: var(--space); | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| backdrop-filter: blur(12px); | ||
| -webkit-backdrop-filter: blur(12px); | ||
| background-color: rgba(255, 255, 255, 0.3); | ||
| } | ||
|
|
||
| article > * { | ||
| grid-column: 2 / 3; | ||
| } | ||
|
|
||
| article > img { | ||
| grid-column: span 3; | ||
| max-height: 300px; | ||
| } | ||
|
|
||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| background-color: rgba(255, 255, 255, 0.9); | ||
| text-align: center; | ||
| padding: 4px 0; | ||
| border-top: 1px solid #ccc; | ||
| font-size: 0.75rem; | ||
| font-weight: 400; | ||
| z-index: 1000; | ||
| line-height: 1.2; | ||
| } | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
| Play with the options that come up. | ||
| https://developer.chrome.com/docs/devtools/css/grid | ||
| https://gridbyexample.com/learn/ | ||
| */ | ||
| main { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| > *:first-child { | ||
| grid-column: span 2; | ||
|
|
||
| @media (max-width: 600px) { | ||
| img { | ||
| max-height: 200px; | ||
| } | ||
| } | ||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
| Now laying out just the INSIDE of the repeated card/article design. | ||
| Keeping things orderly and separate is the key to good, simple CSS. | ||
| */ | ||
| article { | ||
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| > * { | ||
| grid-column: 2/3; | ||
|
|
||
| main { | ||
| grid-template-columns: 1fr; | ||
| padding-bottom: 100px; | ||
| padding: 0 var(--space); | ||
|
|
||
| } | ||
| > img { | ||
| grid-column: span 3; | ||
|
|
||
| main > *:first-child { | ||
| grid-column: auto; | ||
| } | ||
|
|
||
| footer { | ||
| font-size: 0.80rem; | ||
| position: static; | ||
| } | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion -> Adding your name in the footer is a great way to market yourself to employers (once you are building your portfolio and looking for work!).
If you're not comfortable putting your name, that's ok 😃