Sheffield | September | Xiayidan Abudu | Sprint 1 | Wireframe #748

Shayida999 · 2025-09-06T10:48:24Z

✅ Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

📝 Changelist

Completed the Wireframe task from the Form Controls module
Added index.html, style.css, and assets like images and placeholder SVG
Designed layout with 3 articles, responsive for mobile and desktop

Questions

None for now

netlify · 2025-09-06T10:48:28Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`de9a9c6`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68ea2ef453c99000088b3eec
😎 Deploy Preview	https://deploy-preview-748--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-09-06T10:48:37Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions · 2025-09-06T10:48:50Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions · 2025-09-06T11:00:24Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-09-06T11:02:20Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

jenny-alexander · 2025-09-11T03:38:30Z

Your wireframe looks really good - great job!

Here are a few changes I'd like you to implement to improve your application:

The right arrow on the buttons is misleading. This icon is normally used to indicate "play". Can you remove it or use a different one?

The title in your first article has a smaller font than the other articles. According to the wireframe design in the instructions, the article titles should have the same size font.

Formatting your code (within the IDE) helps it to be aligned and easier to maintain. If you right-click in VS Code, you should see the option to 'Format Document' option. Try this and you should see your html file formatted nicely. :)

jenny-alexander · 2025-09-10T12:14:58Z

Wireframe/index.html

-      <p>
-        This is the default, provided code and no changes have been made yet.
-      </p>
+      <p>&copy; 2025 CodeYourFuture — All rights reserved.</p>


Just a suggestion -> Adding your name in the footer is a great way to market yourself to employers (once you are building your portfolio and looking for work!).
If you're not comfortable putting your name, that's ok 😃

…aner UX

jenny-alexander

The changes you made look good - it's much better aligned with the wireframe now 👏

However, I see two issues to resolve before it's complete:

You have a Form-Controls/index.html file included in this PR. This PR should only have work associated with the wireframe exercise.
The buttons in bottom 2 articles are hidden behind the footer. If you look at the wireframe design, you can see that there should be some space between the bottom of the button and the top of the footer.
Can you find a way to fix this?

jenny-alexander · 2025-09-27T22:26:32Z

@Shayida999 It looks like you have deleted the index.html file from the Form-Controls directory. This means that the file will be deleted from the main repository 😱.
We only want the file to be removed from your PR. If you aren't sure, try to find an article online or ask chatGPT how to do this (or ask your fellow CYF trainees).

jenny-alexander

Good job removing the unnecessary files from the PR 👍. I left a few comments for you to look at.
Don't forget to change the label on the PR back to 'Needs Review' once you're ready for me to look at your changes again.

jenny-alexander · 2025-09-27T22:23:53Z

Wireframe/index.html

+        <img src="https://media.geeksforgeeks.org/wp-content/cdn-uploads/20210328185457/How-To-Create-a-Wireframe-in-Software-Design.png" alt="Wireframe design showing page layout" />
+        <h2>WireFrame</h2>
+        <p>A website wireframe, also known as a page schematic or screen blueprint, is a visual guide that represents the skeletal framework of a website.</p>
+        <a href="" target="_blank" rel="noopener noreferrer">Read more</a>


Clicking on the Read More button should bring me to an article about wireframes.

jenny-alexander · 2025-10-04T12:32:19Z

Wireframe/index.html

+        <h2>ReadMe</h2>
+        <p>A README file is a plain text file, often used in software repositories or when sharing datasets, that provides a brief introduction and explanation of the project or data.
+        You can add a README file to your repository to tell other people why your project is useful, what they can do with your project, and how they can use it.</p>
+        <a href="" target="_blank" rel="noopener noreferrer">Read more</a>


@Shayida999 Can you check this link? It should bring the user to an article about readme files.

jenny-alexander · 2025-10-04T12:32:46Z

Wireframe/index.html

+        <h2>Git Branch</h2>
+        <p>In Git, branching allows developers to create independent lines of development, diverging from the main project line and working on new features or bug fixes without affecting the primary codebase.
+        It's like creating a separate "parallel universe" for your code, enabling parallel development efforts.</p>
+        <a href="..." target="_blank" rel="noopener noreferrer">Learn Git Branching</a>


@Shayida999 Can you check this link? It should bring the user to an article about git branches.

illicitonion · 2025-10-11T14:09:50Z

This looks good now, thank you for acting on the feedback!

Shayida999 added 4 commits June 5, 2025 15:33

Complete wireframe task

16a6505

Fix: moved wireframe code to Wireframe folder and deleted extra folder

50e50e1

Remove unwanted wireframe-task folder and files

2738289

ch

da99ff4

Shayida999 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 6, 2025

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 8, 2025

jenny-alexander self-requested a review September 8, 2025 22:36

jenny-alexander reviewed Sep 11, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 11, 2025

Shayida999 added 2 commits September 20, 2025 10:50

Fix: remove arrow icons and unify first article font size

118bd81

Fix form validation and remove <small> tags, add placeholders for cle…

3e35c52

…aner UX

Shayida999 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2025

jenny-alexander suggested changes Sep 20, 2025

View reviewed changes

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2025

Shayida999 added 3 commits September 27, 2025 11:10

Remove Form-Controls file from Wireframe PR

df12af1

Fix footer spacing so buttons are not hidden and update footer text

da21e3b

Fix footer spacing so buttons are not hidden and update footer text

3f6143b

Shayida999 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 27, 2025

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 27, 2025

Shayida999 added 2 commits October 3, 2025 23:29

Restore Form-Controls/index.html and update Wireframe

5e4f747

Remove Form-Controls changes from Wireframe PR

e53cd4f

jenny-alexander suggested changes Oct 4, 2025

View reviewed changes

Fix article links for wireframe, git branch, and README

de9a9c6

Shayida999 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2025

Shayida999 mentioned this pull request Oct 11, 2025

<Sheffield> | Onboarding | <Xiayidan Abuduxukuer> Shayida999/My-Coursework-Planner#51

Open

illicitonion removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2025

illicitonion self-requested a review October 11, 2025 14:09

illicitonion added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Oct 11, 2025

This was referenced Oct 13, 2025

<Sheffield> | Onboarding | <Xiayidan Abuduxukuer> Shayida999/My-Coursework-Planner#52

Closed

<Sheffield> | Onboarding | <Xiayidan Abuduxukuer> #915

Closed

Uh oh!

Sheffield | September | Xiayidan Abudu | Sprint 1 | Wireframe #748

Are you sure you want to change the base?

Sheffield | September | Xiayidan Abudu | Sprint 1 | Wireframe #748

Uh oh!

Conversation

Shayida999 commented Sep 6, 2025

✅ Self checklist

📝 Changelist

Questions

Uh oh!

netlify bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actions bot commented Sep 6, 2025

Uh oh!

github-actions bot commented Sep 6, 2025

Uh oh!

github-actions bot commented Sep 6, 2025

Uh oh!

github-actions bot commented Sep 6, 2025

Uh oh!

jenny-alexander commented Sep 11, 2025

Uh oh!

jenny-alexander Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

jenny-alexander commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jenny-alexander left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

illicitonion commented Oct 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Sep 6, 2025 •

edited

Loading

jenny-alexander commented Sep 27, 2025 •

edited

Loading

jenny-alexander left a comment •

edited

Loading