Skip to content

[Backup] az backup: Fix afs tier filtering for list rps #31890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IannGeorges wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Backup] az backup: Fix afs tier filtering for list rps #31890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/azure-cli/azure/cli/command_modules/backup/custom_afs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,20 +280,24 @@ def list_recovery_points(cmd, client, resource_group_name, vault_name, item, sta
# Prepare to collect tier types
rp_tier_types = []

# Safely grab additional_properties
additional_props = getattr(rp.properties, 'additional_properties', {})
if not isinstance(additional_props, dict):
continue

# Get details list
tier_details_list = additional_props.get("recoveryPointTierDetails", [])
# Get recovery point tier details directly from properties
tier_details_list = getattr(rp.properties, 'recovery_point_tier_details', None)

# If not found, check for the alternate property name
if tier_details_list is None:
tier_details_list = getattr(rp.properties, 'recoveryPointTierDetails', [])

if not isinstance(tier_details_list, list):
continue

for detail in tier_details_list:
if not isinstance(detail, dict):
if hasattr(detail, 'type'):
rp_type = detail.type
elif isinstance(detail, dict):
rp_type = detail.get("type")
else:
continue
rp_type = detail.get("type")

if rp_type:
rp_tier_types.append(rp_type)

Expand Down Expand Up @@ -321,7 +325,6 @@ def list_recovery_points(cmd, client, resource_group_name, vault_name, item, sta

return paged_recovery_points


def update_policy_for_item(cmd, client, resource_group_name, vault_name, item, policy, tenant_id=None,
is_critical_operation=False, yes=False):
if item.properties.backup_management_type != policy.properties.backup_management_type:
Expand Down
Loading