[Backup] az backup: Fix afs tier filtering for list rps
#31890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IannGeorges
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Azure CLI backup module where filtering recovery points by tier type was failing for Azure File Share (AFS) backups due to changes in the API response structure. The fix improves the parsing logic to handle both old and new API response formats for recovery point tier details.
- Updates the recovery point tier parsing logic to access tier details directly from properties
- Adds fallback support for the legacy
recoveryPointTierDetailsproperty name - Improves handling of tier detail objects to support both object attributes and dictionary access patterns
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/backup/custom_afs.py:288
- [nitpick] The property name 'recoveryPointTierDetails' uses camelCase which is inconsistent with Python naming conventions. Consider using 'recovery_point_tier_details' for consistency, though this may be dictated by the API response format.
tier_details_list = getattr(rp.properties, 'recoveryPointTierDetails', [])
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
|
please note that the code completion date for the upcoming release is 08/26/2025 at 07:00 UTC. If you want to catch this release train, please resolve the CI issues ASAP, otherwise it has to be postponed to next sprint (10/14). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
modified the milestones:
September 2025 (2025-09-02),
October 2025 (2025-10-14)
Contributor
|
please resolve CI issues. |
yanzhudd
modified the milestones:
October 2025 (2025-10-14),
November 2025 (2025-11-04)
zhoxing-ms
modified the milestones:
November 2025 (2025-11-04),
November 2025 (2025-11-18)❗ Breaking change release ❗
zhoxing-ms
changed the title
az backup: Fix afs tier filtering for list rps
Contributor
|
@IannGeorges Any update? |
zhoxing-ms
modified the milestones:
November 2025 (2025-11-18)❗ Breaking change release ❗,
December 2025 (2025-12-02)
yanzhudd
modified the milestones:
December 2025 (2025-12-02),
January 2026 (2026-01-06)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az backup recoverypoint list
Description
The API response has changed, resulting in correct parsing of the Recovery Point tier details, preventing users from using filtering.
Testing Guide
Tested filtering list of recovery point for an existing AFS backup before changes were made to reproduce bug.
Tested filtering list of recovery point for an existing AFS backup after changes were made to validate fix.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.