Skip to content

[Common] Extend TOF Response parameters as a service #11872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 4 commits into from
Oct 21, 2025
Merged

[Common] Extend TOF Response parameters as a service #11872

njacazio merged 4 commits into from
Oct 21, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jul 2, 2025

No description provided.

@github-actions github-actions bot changed the title Add TOF Response parameters as a service [Common] Add TOF Response parameters as a service Jul 2, 2025
@github-actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@njacazio
Copy link
Collaborator Author

njacazio commented Jul 2, 2025

First step of #11806

@njacazio njacazio force-pushed the nj-tofserviceparam-1 branch 2 times, most recently from cda638b to ff8648e Compare July 2, 2025 10:01
@njacazio njacazio marked this pull request as ready for review July 2, 2025 10:05
@njacazio njacazio requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners July 2, 2025 10:05
@njacazio njacazio enabled auto-merge (squash) July 2, 2025 13:43
@njacazio njacazio marked this pull request as draft July 16, 2025 11:41
auto-merge was automatically disabled July 16, 2025 11:41

Pull request was converted to draft

@njacazio njacazio mentioned this pull request Jul 16, 2025
Merged
@njacazio njacazio marked this pull request as ready for review August 1, 2025 09:01
@njacazio
Copy link
Collaborator Author

njacazio commented Aug 1, 2025

O2 PR merged, ready to move on

@alibuild
Copy link
Collaborator

alibuild commented Aug 1, 2025

Error while checking build/O2Physics/o2 for 5c9a477 at 2025-08-01 12:09:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera requested changes Aug 1, 2025
View reviewed changes
@vkucera vkucera marked this pull request as draft August 13, 2025 07:54
@njacazio njacazio force-pushed the nj-tofserviceparam-1 branch from 5c9a477 to 028ef2a Compare August 26, 2025 12:54
@njacazio njacazio force-pushed the nj-tofserviceparam-1 branch from 028ef2a to 32c1c7d Compare August 26, 2025 12:55
@njacazio njacazio changed the title [Common] Add TOF Response parameters as a service [Common] Extend TOF Response parameters as a service Aug 26, 2025
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label Sep 26, 2025
vkucera
vkucera previously approved these changes Sep 26, 2025
View reviewed changes
@github-actions github-actions bot removed the stale label Sep 27, 2025
@njacazio
Copy link
Collaborator Author

njacazio commented Oct 17, 2025

Enabled by AliceO2Group/AliceO2#14730

@njacazio njacazio marked this pull request as ready for review October 17, 2025 19:37
@njacazio njacazio mentioned this pull request Oct 17, 2025
Merged
@njacazio njacazio enabled auto-merge (squash) October 20, 2025 09:20
@alibuild
Copy link
Collaborator

alibuild commented Oct 20, 2025

Error while checking build/O2Physics/o2 for f595072 at 2025-10-20 14:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11872-slc9_x86-64/0/Common/Core/PID/PIDTOFParamService.cxx:19:10: fatal error: PIDTOFService.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio merged commit 6f4e9ac into AliceO2Group:master Oct 21, 2025
12 checks passed
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@njacazio @ThePhDane
[Common] Extend TOF Response parameters as a service (AliceO2Group#11872
e908725 
)
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@njacazio
[Common] Extend TOF Response parameters as a service (AliceO2Group#11872
252bf10 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common datamodel

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njacazio @alibuild @vkucera @ddobrigk