Skip to content

Conversation

@njacazio
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@njacazio njacazio changed the title Split param tof utilities TOF: Split param utilities for lower memory usage in O2Physics Jul 15, 2025
@njacazio
Copy link
Collaborator Author

needed for AliceO2Group/O2Physics#11872

@njacazio njacazio marked this pull request as ready for review July 16, 2025 11:41
@njacazio njacazio requested a review from noferini as a code owner July 16, 2025 11:41
@njacazio njacazio changed the title TOF: Split param utilities for lower memory usage in O2Physics TOF: Header only param utilities libraryless call in O2Physics Jul 16, 2025
@alibuild
Copy link
Collaborator

alibuild commented Jul 16, 2025

Error while checking build/O2/fullCI_slc9 for 5efd4c2 at 2025-07-22 00:59:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14516-slc9_x86-64/0/Detectors/TOF/workflow/src/make-parameter-collection.cxx:66:3: error: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@njacazio njacazio enabled auto-merge (squash) July 16, 2025 13:05
Copy link
Collaborator

@noferini noferini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine with me.
FullCI test failed at the start. It is not an issue related to this PR.

@njacazio
Copy link
Collaborator Author

Hi. Could this be merged? Thanks!

@shahor02 shahor02 disabled auto-merge August 1, 2025 08:43
@shahor02 shahor02 merged commit 1aa2c14 into AliceO2Group:dev Aug 1, 2025
12 of 13 checks passed
@njacazio njacazio deleted the nj-paramtof branch August 1, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants