Skip to content

TRD: decrease default --max-delay for gain, t0, vdexb calibrations #14478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Jul 4, 2025
Merged

TRD: decrease default --max-delay for gain, t0, vdexb calibrations #14478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Detectors/TRD/workflow/include/TRDWorkflow/GainCalibSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class GainCalibDevice : public o2::framework::Task
{
o2::base::GRPGeomHelper::instance().setRequest(mCCDBRequest);
auto slotL = ic.options().get<uint32_t>("sec-per-slot");
auto delay = ic.options().get<uint32_t>("max-delay");
auto delay = ic.options().get<float>("max-delay");
mCalibrator = std::make_unique<o2::trd::CalibratorGain>();
mCalibrator->setSlotLengthInSeconds(slotL);
mCalibrator->setMaxSlotsDelay(delay);
Expand Down Expand Up @@ -155,7 +155,7 @@ DataProcessorSpec getTRDGainCalibSpec()
AlgorithmSpec{adaptFromTask<o2::calibration::GainCalibDevice>(ccdbRequest)},
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::Float, 0.05f, {"number of slots in past to consider"}},
{"enable-root-output", VariantType::Bool, false, {"output tprofiles and fits to root file"}},
}};
}
Expand Down
4 changes: 2 additions & 2 deletions Detectors/TRD/workflow/include/TRDWorkflow/T0FitSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class T0FitDevice : public o2::framework::Task
{
o2::base::GRPGeomHelper::instance().setRequest(mCCDBRequest);
auto slotL = ic.options().get<uint32_t>("sec-per-slot");
auto delay = ic.options().get<uint32_t>("max-delay");
auto delay = ic.options().get<float>("max-delay");

mFitInstance = std::make_unique<o2::trd::T0Fit>();
mFitInstance->setSlotLengthInSeconds(slotL);
Expand Down Expand Up @@ -159,7 +159,7 @@ DataProcessorSpec getTRDT0FitSpec()
AlgorithmSpec{adaptFromTask<device>(ccdbRequest)},
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::Float, 0.05f, {"number of slots in past to consider"}},
{"enable-root-output", VariantType::Bool, false, {"output t0 values to root file"}},
}};
}
Expand Down
4 changes: 2 additions & 2 deletions Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class VdAndExBCalibDevice : public o2::framework::Task
{
o2::base::GRPGeomHelper::instance().setRequest(mCCDBRequest);
auto slotL = ic.options().get<uint32_t>("sec-per-slot");
auto delay = ic.options().get<uint32_t>("max-delay");
auto delay = ic.options().get<float>("max-delay");
mCalibrator = std::make_unique<o2::trd::CalibratorVdExB>();
mCalibrator->setSlotLengthInSeconds(slotL);
mCalibrator->setMaxSlotsDelay(delay);
Expand Down Expand Up @@ -158,7 +158,7 @@ DataProcessorSpec getTRDVdAndExBCalibSpec()
AlgorithmSpec{adaptFromTask<device>(ccdbRequest)},
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::Float, 0.05f, {"number of slots in past to consider"}},
{"enable-root-output", VariantType::Bool, false, {"output tprofiles and fits to root file"}},
}};
}
Expand Down