Skip to content

TRD: decrease default --max-delay for gain, t0, vdexb calibrations #14478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 1 commit into from
Jul 4, 2025
Merged

TRD: decrease default --max-delay for gain, t0, vdexb calibrations #14478

shahor02 merged 1 commit into from
Jul 4, 2025

Conversation

@ehellbar
Copy link
Collaborator

@ehellbar ehellbar commented Jul 3, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

shahor02
shahor02 requested changes Jul 3, 2025
View reviewed changes
Detectors/TRD/workflow/include/TRDWorkflow/GainCalibSpec.h Outdated
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::UInt32, 0.05f, {"number of slots in past to consider"}},
Copy link
Collaborator

@shahor02 shahor02 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be VariantType::Float

Copy link
Collaborator Author

@ehellbar ehellbar Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, sorry about that

Detectors/TRD/workflow/include/TRDWorkflow/T0FitSpec.h Outdated
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::UInt32, 0.05f, {"number of slots in past to consider"}},
Copy link
Collaborator

@shahor02 shahor02 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h Outdated
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::UInt32, 0.05f, {"number of slots in past to consider"}},
Copy link
Collaborator

@shahor02 shahor02 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

@alibuild
Copy link
Collaborator

alibuild commented Jul 3, 2025

Error while checking build/O2/fullCI_slc9 for 256f5b5 at 2025-07-03 19:28:

## sw/BUILD/d0022fa1d8f48efab01a1ea2ec0aa9eb5d65ca9f-latest/log
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: 'VariantType' is not a member of 'o2::framework::VariantType'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: no matching function for call to 'std::vector<o2::framework::ConfigParamSpec>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:154:27: error: expected primary-expression before '{' token
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:154:27: error: expected ';' before '{' token
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: 'VariantType' is not a member of 'o2::framework::VariantType'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: no matching function for call to 'std::vector<o2::framework::ConfigParamSpec>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:159:12: error: expected primary-expression before '{' token
ninja: build stopped: subcommand failed.


## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: 'VariantType' is not a member of 'o2::framework::VariantType'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: no matching function for call to 'std::vector<o2::framework::ConfigParamSpec>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:154:27: error: expected primary-expression before '{' token
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:154:27: error: expected ';' before '{' token
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: 'VariantType' is not a member of 'o2::framework::VariantType'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:161:34: error: no matching function for call to 'std::vector<o2::framework::ConfigParamSpec>::vector(<brace-enclosed initializer list>)'
/sw/SOURCES/O2/14478-slc9_x86-64/0/Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h:159:12: error: expected primary-expression before '{' token
ninja: build stopped: subcommand failed.

Full log here.

shahor02
shahor02 reviewed Jul 3, 2025
View reviewed changes
Detectors/TRD/workflow/include/TRDWorkflow/VdAndExBCalibSpec.h Outdated
Options{
{"sec-per-slot", VariantType::UInt32, 900u, {"number of seconds per calibration time slot"}},
{"max-delay", VariantType::UInt32, 2u, {"number of slots in past to consider"}},
{"max-delay", VariantType::VariantType::Float, 0.05f, {"number of slots in past to consider"}},
Copy link
Collaborator

@shahor02 shahor02 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 variant :)

@shahor02 shahor02 merged commit b562533 into AliceO2Group:dev Jul 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

@f3sch f3sch Awaiting requested review from f3sch f3sch is a code owner

@bazinski bazinski Awaiting requested review from bazinski bazinski is a code owner

@wille10 wille10 Awaiting requested review from wille10 wille10 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehellbar @alibuild @shahor02