Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Jun 19, 2025

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@vkucera
Copy link
Collaborator Author

vkucera commented Jun 19, 2025

FYI @ktf

@vkucera
Copy link
Collaborator Author

vkucera commented Jun 23, 2025

@fprino @mconcas @shahor02 Does it look fine to you?

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkucera in principle, it would be better to move the functions to cxx, then in the header it would be enough to have #include <map> and forward declaration of the NoiseMap.

If you want, I can do this.

@vkucera
Copy link
Collaborator Author

vkucera commented Jun 23, 2025

@vkucera in principle, it would be better to move the functions to cxx, then in the header it would be enough to have #include <map> and forward declaration of the NoiseMap.

If you want, I can do this.

Hi @shahor02 , that would be great, thanks. Whatever makes the header self-sufficient works.

@shahor02
Copy link
Collaborator

@vkucera #14436

@vkucera
Copy link
Collaborator Author

vkucera commented Jun 23, 2025

@vkucera #14436

Thanks @shahor02 !

@vkucera vkucera marked this pull request as draft June 24, 2025 09:19
@vkucera vkucera force-pushed the iwyu-time-dead-map branch from fcbed15 to 7264aa3 Compare July 9, 2025 15:49
@vkucera vkucera force-pushed the iwyu-time-dead-map branch from 7264aa3 to 2ff61a2 Compare July 9, 2025 15:50
@vkucera vkucera marked this pull request as ready for review July 9, 2025 15:51
@alibuild
Copy link
Collaborator

alibuild commented Jul 9, 2025

Error while checking build/O2/fullCI_slc9 for 2ff61a2 at 2025-07-15 05:45:

No log files found

Full log here.

@vkucera vkucera requested a review from shahor02 July 10, 2025 11:58
@vkucera
Copy link
Collaborator Author

vkucera commented Jul 21, 2025

@shahor02 @mconcas Can we merge this once the macOS build recovers?

@shahor02 shahor02 merged commit d53e9d9 into AliceO2Group:dev Jul 21, 2025
10 of 11 checks passed
@vkucera vkucera deleted the iwyu-time-dead-map branch July 21, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants