[Common] Fix bugs, bad practice, performance, includes

[vkucera]

• Fix bugs:
  • Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. (cppcheck)
    • Common/TableProducer/eventSelection.cxx (1)
    • Common/Tasks/trackqa.cxx (1)
    • Common/Tools/EventSelectionTools.h (1)
  • abs(float) (O2 linter)
    • Common/TableProducer/PID/pidBayes.cxx (1)
    • Common/TableProducer/PID/pidTOFBase.cxx (2)
  • Condition ... is always false. (cppcheck)
    • Common/Tools/EventSelectionTools.h: Missing bcs size check.
  • Member variable ... is not initialized (in the constructor). (cppcheck)
    • Common/TableProducer/PID/pidTOFMerge.cxx (5)
    • Common/TableProducer/caloClusterProducer.cxx (3)
    • Common/Tools/Multiplicity/multGlauberNBDFitter.cxx (2)
    • Common/Tools/TrackPropagationModule.h (1)
    • Common/Tools/trackSelectionRequest.h (1)
• Fix bad practice:
  • Local variable ... shadows outer variable/function. (cppcheck)
  • Variable/Parameter ... can be declared as (reference to) const ... (cppcheck)
  • Class ... has a constructor with 1 argument that is not explicit. (cppcheck)
    • OrbitRange
    • multCalibrator
    • multGlauberNBDFitter
    • multMCCalibrator
  • Variable ... is reassigned a value before the old one has been used. (cppcheck)
    • Common/TableProducer/multiplicityTable.cxx (6)
  • The if condition is the same as the previous if condition. (cppcheck)
  • C-style casting (cppcheck, cpplint)
  • Use constant references for table subscriptions in process functions. (O2 linter)
    • Common/TableProducer/PID/pidTOFBase.cxx (2)
  • Use constant references for non-modified iterators in range-based for loops. (O2 linter)
  • string -> std::string (Confuses IWYU in clang-tidy because of using std::string directive in TJAlienCredentials.h.)
• Improve performance:
  • Function parameter ... should be passed by const reference. (cppcheck)
    • Maaaany...
• Fix header including.
  • Fix header guards. (cpplint)
  • Add missing C++ system header includes. (cpplint)
  • Fix include order. (clang-format, manual)
  • Fix include format. (Scripts/format_includes.awk)
  • Replace fairlogger/Logger.h with Framework/Logger.h.
  • Fix incomplete paths.
• Delete unused file.
  • Common/Tasks/evtPlanesResolution.cxx

[github-actions]

O2 linter results: ❌ 914 errors, ⚠️ 0 warnings, 🔕 96 disabled

[vkucera]

FYI @ekryshen @altsybee

[ddobrigk]

Thanks @vkucera - marked as draft, should be handled after #11613

[vkucera]

Thanks @vkucera - marked as draft, should be handled after #11613

No problem. Can you fix those bugs there too?

[vkucera]

#11613

@ddobrigk PR #11613 was merged without applying fixes from this PR. How do you plan to proceed?