Skip to content

fix scrollbar visibility & popup position #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masano wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix scrollbar visibility & popup position #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions jqselectable/jqselectable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
self.selected = undefined;
self.selected_id = undefined;

self.has_no_maxheight = typeof document.body.style.maxHeight;
self.has_maxheight = typeof document.body.style.maxHeight;

// id
self.id = self.elem.id || 'jqs_' + parseInt(Math.random()*1000);
Expand Down Expand Up @@ -138,11 +138,13 @@
scroll_top = get_scrolltop(),
client_height = get_clientheight();

if ( client_height / 2 < pos.top - scroll_top ) {
top_pos = pos.top - self.list_height + conf.top - 5;
} else {
top_pos = pos.top + $view.height() * 1.3 + conf.top;
}
// popup below if there are space below or there are no vacant above popup element
if (client_height + scroll_top - pos.top - $view.height() * 1.3 > self.list_height
|| pos.top - scroll_top < self.list_height) {
top_pos = pos.top + $view.height() * 1.3 + conf.top;
} else {
top_pos = pos.top - self.list_height + conf.top - 5;
}

$list.css({
top: top_pos,
Expand Down Expand Up @@ -211,7 +213,7 @@
$elem = self.$elem;

// for IE6
if ( self.has_no_maxheight ) {
if ( ! self.has_maxheight ) {
body_style = 'height: ' + height + '; overflow-y: scroll;';
// for other browsers
} else {
Expand Down Expand Up @@ -429,7 +431,7 @@

self._build();
self._eventify();

self.$elem.trigger('jQselectable.refresh');
},

Expand Down
2 changes: 1 addition & 1 deletion jqselectable/jqselectable.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.