Fix fallback logic when starting up with an unsupported EZSP version #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #705 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 58 58
Lines 4128 4128
=======================================
Hits 4109 4109
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested EZSPv18 a bit more thoroughly and while the frame format has indeed changed, it didn't actually change in any way that impacts bellows operation: it should have been supported by "falling back" to EZSPv17 parsing and logic.
ZHA startup fails because config writing tried to look up config for the exact version in our global config, which will fail. We should instead fall back to the latest version's config.
Should resolve home-assistant/core#160051