coredump: partially fix ruff warnings and formatting #100602
Open
+220
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
force-pushed
the
coredump/ruff
branch
from
a82d98e to
f11109b
Compare
This disables the duplicate code warnings on x86 and x86_64 gdbstubs. The exception vector tables may look the same now but can deviate depending on supported features on architecture. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This is done via "ruff format" without any manual editing. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This fixes ruff warnings on top level coredump scripts. This is done via "ruff check --fix" without manual editing. Note SIM115 is not fixed yet as it requires more intrusive changes to handle opened file with context manager. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This fixes ruff warnings on coredump parser scripts. Note SIM115 is not fixed yet as it requires more intrusive changes to handle opened file with context manager. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This fixes ruff warnings on coredump gdbstuc scripts. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
|
zephyrbot
requested review from
kartben,
keith-zephyr,
mrkhldn,
nashif and
pdgendt
pdgendt
approved these changes
Dec 5, 2025
| self.registers[reg_num] = tu[i] | ||
| i += 1 | ||
|
|
||
| i = i + 1 |
Contributor
There was a problem hiding this comment.
Not sure why there was no suggestion made to use enumerate 🤷
nashif
approved these changes
Dec 6, 2025
teburd
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ruff warnings on coredump scripts, and also formats those scripts via ruff.
Note SIM115 is not fixed yet as it requires more intrusive changes to handle opened file with context manager.