-
Notifications
You must be signed in to change notification settings - Fork 17
Skip parsing of transitional keyword #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
This allows to parse configs with the transitional key word. For a working version of the transitional feature it is necessary to extend parsing of the default keyword to support setting the value to a variable: ``` config NEW_BOOL bool "New bool option" default OLD_BOOL ``` Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution.
However, i'm not immediately convinced that we should just silence / ignore the transitional keyword.
Skipping the transitional keyword means that the symbol holding this keyword suddenly becomes a valid symbol again, which potentially can enter the .config file.
Also it seems that this silencing will allow invalid config descriptions, such as having prompts on settings with the transitional keyword.
I do understand the wish for being able to parse Kconfig trees having transitional attribute, but when supporting / silencing this attribute then we should not allow invalid Kconfig files in that same process.
If not supporting the attribute but still allowing it to be present, then such implementation should still ensure the symbol does not become or behave like a regular Kconfig symbol, which unfortunately would be the case with this PR.
I hope to find time to look into proper support for transitional.
|
Proper support would be better. This was short fix to get our own use case working again. The skip looked correct in my initial testing expect the missing assignment of value, which uses the default symbol mentioned in issue #31 : Comment: Fixed typo |
my main problem with the current PR as it stands is that it allows invalid Kconfig definition like this: according to the specification, this symbol definition is illegal, but with this PR this syntax is accepted because the transitional keyword is silently ignored. I think it's worse to silently accept invalid Kconfig constructions, than it is to be lacking a feature. Note, there might be other issues regarding the PR, but this is the main one I've found so far. |
This skips the transitional keyword to allow parsing of kernel config of Linux kernel => 6.18. It does not implement the transitional feature as this requires additional changes.
Also add the test files to .gitignore.
This fixes #25.