New approach: Find child process bases on parent id and name #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quangnt
force-pushed
the
fix-error-when-close-launched-application
branch
3 times, most recently
from
496ac5e to
ef8b13b
Compare
Author
|
@zelonght Implement new way as we discussed yesterday. Can you review? |
| children = this.Automator.Application.GetChildPrecesses(this.Automator.Application.GetProcessId()); | ||
| if (children.Count == 0) | ||
| { | ||
| children = this.Automator.Application.GetAllPrecessesByName(this.Automator.Application.GetProcessName()); |
Owner
There was a problem hiding this comment.
GetAllPrecessesByName --> is this sure that this is the sub/child process ? Let's discuss this.
quangnt
force-pushed
the
fix-error-when-close-launched-application
branch
from
ef8b13b to
ff484ed
Compare
Author
|
@zelonght Addressed comments. Can you review it again? |
| <Compile Include="CommandExecutors\NotImplementedExecutor.cs" /> | ||
| <Compile Include="CommandExecutors\SwitchToWindowExecutor.cs" /> | ||
| <Compile Include="CommandLineOptions.cs" /> | ||
| <Compile Include="CommonHelpers\CommonHelpers.cs" /> |
Owner
There was a problem hiding this comment.
- There is already CommandHelpers we don't need to have CommonHelpers --> let's use what exists.
- CommonHelpers is too common and general, look at the author is doing, each helper must have its meaning (e.g. OSInfo.cs or BuildInfo.cs ==> Let's use something like
TerminateApp.cs
Owner
|
@quangnt Commit text please add the JIRA card too. |
Owner
|
@quangnt Review done, please address comments |
quangnt
force-pushed
the
fix-error-when-close-launched-application
branch
from
516ea8d to
4ab296d
Compare
Author
|
@zelonght @KhanhLanHuynh LT, addressed comments on this PR. Can you review? |
Owner
|
👍 |
Owner
|
@KhanhLanHuynh @longk15t @phienpham Your turn to finalize this before new sprint start next week. |
|
@zelonght sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.