Revert quoting all paths on Windows #161
Open
+32
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tartarughina
commented
Dec 22, 2025
tartarughina
commented
- Add double quotes only to paths that are going to be used by the node proxy as args
- Rust functions are already handling the instance where a space is present in the path
- Add double quotes only to paths that are going to be used by the node proxy as args - Rust functions are already handling the instance where a space is present in the path
1 task
- Remove the shell mode from the proxy for Win32 as no longer relying on jdtls.bat - Remove quoting function along with tests
playdohface
reviewed
Dec 25, 2025
Collaborator
playdohface
left a comment
playdohface
left a comment
There was a problem hiding this comment.
Am I understanding this correctly that we don't launch java.exe through a shell at all, and only launch scripts in Windows need a shell?
| const lsp = spawn(command, args, { | ||
| shell: isWindows, | ||
| detached: false | ||
| shell: (isWindows && bin.endsWith(".bat")) ? true : false, |
Collaborator
There was a problem hiding this comment.
nit: unnecessary ternary expression here. But if we always have to predicate isWindows with bin.endsWith(".bat"), we might factor that out.
Collaborator
Author
|
Correct, a .bat needs a shell while a .exe works without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.